Closed mdornseif closed 6 years ago
Merging #5 into master will increase coverage by
0.12%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #5 +/- ##
==========================================
+ Coverage 96.68% 96.81% +0.12%
==========================================
Files 10 11 +1
Lines 453 471 +18
==========================================
+ Hits 438 456 +18
Misses 15 15
Impacted Files | Coverage Δ | |
---|---|---|
tests/test_00800302_b2b.py | 100% <100%> (ø) |
|
sepadd/debit.py | 97.49% <100%> (+0.01%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3ad68f5...878323d. Read the comment docs.
Hi! :) Thank you!
I tried to also extend the tests but since there is no documentation on how to run them I did not test the tests ;-) You can run them like this:
pip install -r requirements_dev.txt
py.test tests
Would you mind splitting the test such that there is one test using CORE and one using B2B?
Sure. I hope this is what you had in mind.
Yep, looks good. Only issue:
ERROR: /home/travis/build/raphaelm/python-sepadd/tests/test_00800302_b2b.py Imports are incorrectly sorted.
Could you run isort -rc .
to fix that automatically? :)
sigh. … disable Sublime Fix Imports … find isort … understand isort (ah, -sl
is the way it's formated here) … install isort … excute, comit, push
… feels like contributing to Mozilla.
sigh. … disable Sublime Fix Imports … find isort … understand isort (ah, -sl is the way it's formated here) … install isort … excute, comit, push
Sorry you had this experience :\ I'll try to improve on documentation. However, -sl
shouldn't have been required since travis just checks with isort -rc -c sepadd tests
, so with no special configuration.
Thanks! :)
I tried to also extend the tests but since there is no documentation on how to run them I did not test the tests ;-)