search

raphaelm / python-sepaxml

SEPA Direct Debit XML generation in python
MIT License
110 stars 42 forks source link

Describe how to run tests, fix encodings #6

Closed mdornseif closed 6 years ago

mdornseif commented 6 years ago

Tests failed on my machine (Mac OS 10.13, vanilla Python 2.7) with SyntaxError: Non-ASCII character '\xc3' in file /Users/md/github/python-sepadd/tests/test_escaped.py on line 202, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details

I assume other Developers have defined a default encoding on their machine. This fix defines an encoding and uses a Unicode String for non ASCII Strings in the tests.

codecov[bot] commented 6 years ago

Codecov Report

Merging #6 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files          10       10           
  Lines         453      453           
=======================================
  Hits          438      438           
  Misses         15       15
Impacted Files Coverage Δ
tests/test_escaped.py 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ad68f5...d7d2c87. Read the comment docs.

raphaelm commented 6 years ago

The ascii problem is not due to encoding but due to another problem: You're running old Python. We do not support Python 2.7 any more. I'd gladly merge the changes to the documentation (but only them).