raphaelmor / Polyline

Polyline encoder / decoder in swift
MIT License
299 stars 50 forks source link

Set SWIFT_VERSION in the podspec #37

Closed frederoni closed 8 years ago

tomtaylor commented 8 years ago

My understanding is that Cocoapods 1.1.0 will detect based on the .swift-version file. Can you explain more about why this is required?

frederoni commented 8 years ago

@tomtaylor I think .swift-version is interpreted when you run the program via CLI or swiftenv for example. CocoaPods/CocoaPods#5540 indicates that it will be extracted from the target but 1.1.0 is not yet released.

aataraxiaa commented 8 years ago

@tomtaylor @frederoni I wrote this recently when updating one of my pods - https://medium.com/@superpeteblaze/swift-3-cocoapods-ccb72e0de750#.lzth4e9s2

frederoni commented 8 years ago

Thanks @superpeteblaze Indeed it works with rc.2 but the fix in this PR works with the latest stable release of cocoapods. @tomtaylor you can go ahead and delete this PR unless you want to support older versions of cocoapods.

tomtaylor commented 8 years ago

@frederoni thanks, I think there's probably other Xcode 8 stuff that Cocoapods 1.1.0 will/does support, so it's not unreasonable to expect people to update. I'll close this.