raphaelquast / EOmaps

A library to create interactive maps of geographical datasets
https://eomaps.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
339 stars 25 forks source link

Improvements to contributing guide #213

Closed banesullivan closed 11 months ago

banesullivan commented 11 months ago

Here is a draft of some improvements to the contributing guide for you to run with. Would you please update this to your liking and make sure it has clear instructions for local development and testing?

For https://github.com/pyOpenSci/software-submission/issues/138

raphaelquast commented 11 months ago

Thank you very much for opening this PR! Highly appreciated! I'll report back once it's finished.

raphaelquast commented 11 months ago

Hey @banesullivan Both CONTRIBUTING.md and the associated Contribution Guide in the docs are now updated to include infos on tests etc.

Please let me know if you are OK with the changes!

If yes, I'll merge this PR into dev so it will be included in the next release!

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3313346) 76.71% compared to head (6b0717f) 76.71%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #213 +/- ## ======================================= Coverage 76.71% 76.71% ======================================= Files 23 23 Lines 11155 11155 ======================================= + Hits 8557 8558 +1 + Misses 2598 2597 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

raphaelquast commented 11 months ago

Thanks for your support and your prompt feedback!