search

raphaelquast / EOmaps

A library to create interactive maps of geographical datasets
https://eomaps.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
339 stars 25 forks source link

Maps crs param not following community already established practices #253

Open salahelfarissi opened 3 weeks ago

salahelfarissi commented 3 weeks ago

Describe the bug

This is not a bug. But since I use EOmaps a lot. I always correct myself when defining my map crs. I'm used to work with pyproj and geopandas crs param. Normally crs will be of form f"EPSG:{NUMBER}" and epsg of form NUMBER. Maps crs param is of form NUMBER.

For example _df_to_geodf https://github.com/geopandas/geopandas/blob/main/geopandas/io/sql.py#L45

raphaelquast commented 3 weeks ago

Hey, thanks for opening the issue (and nice to hear you're using EOmaps on a regular basis!)

While I definitely want to keep the option of passing epsg-codes directly as integers, supporting a syntax like "EPSG:{NUMBER}" is indeed a nice addition and should be fairly easy to implement by adding a string-parsing option to the _get_cartopy_crs method.

It might take a bit until I find the time to implement this myself, but I'd be happy to accept a PR that implements this feature! The method is here: https://github.com/raphaelquast/EOmaps/blob/66d32e2f5219059ab32a02457c535652d3e3f881/eomaps/_maps_base.py#L1162-L1186