raphaelquintao / QRedshiftCinnamon

Linux Cinnamon applet to change screen color temperature
https://cinnamon-spices.linuxmint.com/applets/view/313
Apache License 2.0
96 stars 13 forks source link

change default keyboard shortcuts #22

Closed jonorthwash closed 3 years ago

jonorthwash commented 3 years ago

After a recent update, I found that I wasn't able to change tabs in my browser, terminal, messaging client, and other programs, using the Ctrl+PgUp and Ctrl+PgDn shortcuts.

It turned out that during the update, QRedshift overrode those shortcuts without my knowledge—I was able to figure this out only after scouring the internet until I found someone else who'd had the same problem and managed to figure it out. Like them, I was worried something had broken.

The Ctrl+PgUp and Ctrl+PgDn shortcuts are the default way to alternate between tabs in nearly every program I've ever used that has tabs (and in many cases it's hard-coded). QRedshift should not override any system-level keyboard shortcuts, much less these. At worst it should tell the user that there are new shortcuts available that need to be set. QRedshift is the sort of program you expect to set up once and ignore unless something changes, and not the sort of program you expect to make it impossible to switch between tabs just because there's a new version.

Note: this functionality was added in #9 based on #8.

raphaelquintao commented 3 years ago

I will remove that o next release, was a big mistake... that happens... =D

raphaelquintao commented 3 years ago

Fixed https://github.com/raphaelquintao/QRedshift/commit/e78d13da7e158f9891df4e9fdd1ca53a1885ecda#diff-fdf323b43304316f2a5ef56a0fbb6487d222e35617efeb0f8309fb7cdf00c8fc