search

raphaelquintao / QRedshiftCinnamon

Linux Cinnamon applet to change screen color temperature
https://cinnamon-spices.linuxmint.com/applets/view/313
Apache License 2.0
98 stars 13 forks source link

redshift includes multiple methods in its command line #26

Closed dilinger closed 3 years ago

dilinger commented 3 years ago

While debugging a separate issue, I noticed that qredshift is passing the -m argument to redshift multiple times. I added the following code to redShiftUpdate():

this.doCommand(cmd); qLOG('doCommand(' + cmd + ')');

In the log, I see:

Cjs-Message: 21:45:26.322: JS LOG: [LookingGlass/warning] "doCommand(redshift -c /home/dilinger/.local/share/cinnamon/applets/qredshift@quintao/assets/base.conf -P -r -v -o -m randr -m randr -l 40.7229:-73.8473 -t 5900:1956 -b 0.87:0.87 -g 1 )"

You can see the '-m randr -m randr' duplicate arguments. Minor bug, but probably worth fixing.

dilinger commented 3 years ago

This appears to be fixed with 1.5.3:

Cjs-Message: 19:33:39.024: JS LOG: [LookingGlass/warning] "doCommand(redshift -P -r -v -o -m randr -l 40.7229:-73.8473 -t 5900:2982 -b 0.89:0.89 -g 1 )"