raphaelvallat / pingouin

Statistical package in Python based on Pandas
https://pingouin-stats.org/
GNU General Public License v3.0
1.61k stars 138 forks source link

hotfix: plot_rm_corr crash with specific column names #351

Closed remrama closed 1 year ago

remrama commented 1 year ago

Should address #349

I added the assertion checks right above the use of ols as opposed to start of each function, only because it seemed easier for a reader to extract the motivation for them. lmk if you prefer them at the top.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (8c92b6d) 98.53% compared to head (af061bc) 98.54%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #351 +/- ## ======================================= Coverage 98.53% 98.54% ======================================= Files 19 19 Lines 3353 3361 +8 Branches 545 547 +2 ======================================= + Hits 3304 3312 +8 Misses 26 26 Partials 23 23 ``` | [Impacted Files](https://codecov.io/gh/raphaelvallat/pingouin/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Raphael+Vallat) | Coverage Δ | | |---|---|---| | [pingouin/parametric.py](https://codecov.io/gh/raphaelvallat/pingouin/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Raphael+Vallat#diff-cGluZ291aW4vcGFyYW1ldHJpYy5weQ==) | `99.56% <100.00%> (+<0.01%)` | :arrow_up: | | [pingouin/plotting.py](https://codecov.io/gh/raphaelvallat/pingouin/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Raphael+Vallat#diff-cGluZ291aW4vcGxvdHRpbmcucHk=) | `95.76% <100.00%> (+0.03%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Raphael+Vallat). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Raphael+Vallat)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.