raphaelvallat / yasa

YASA (Yet Another Spindle Algorithm): a Python package to analyze polysomnographic sleep recordings.
https://raphaelvallat.com/yasa/
BSD 3-Clause "New" or "Revised" License
428 stars 115 forks source link

Solves obscure numba bug with just replacing range -> zip #115

Closed remrama closed 1 year ago

remrama commented 1 year ago

Solves an obscure numba bug (specifically in yasa.numba._corr) that was popping up for only some users/systems. See the madness in #107.

Note: I thought it would be best to add some new tests for this, but I looked and the current tests in test_numba.py do catch it. So it's really just specific to some systems that don't get run during the unittests.

codecov-commenter commented 1 year ago

Codecov Report

Base: 91.47% // Head: 91.47% // No change to project coverage :thumbsup:

Coverage data is based on head (4f18416) compared to base (806b08f). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #115 +/- ## ======================================= Coverage 91.47% 91.47% ======================================= Files 22 22 Lines 2674 2674 ======================================= Hits 2446 2446 Misses 228 228 ``` | [Impacted Files](https://codecov.io/gh/raphaelvallat/yasa/pull/115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Raphael+Vallat) | Coverage Δ | | |---|---|---| | [yasa/numba.py](https://codecov.io/gh/raphaelvallat/yasa/pull/115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Raphael+Vallat#diff-eWFzYS9udW1iYS5weQ==) | `21.66% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Raphael+Vallat). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Raphael+Vallat)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

raphaelvallat commented 1 year ago

Awesome, thanks! Merging now.