search

raphaelvallat / yasa

YASA (Yet Another Spindle Algorithm): a Python package to analyze polysomnographic sleep recordings.
https://raphaelvallat.com/yasa/
BSD 3-Clause "New" or "Revised" License
428 stars 115 forks source link

Error while using topoplot() function #140

Closed k0ruy closed 10 months ago

k0ruy commented 1 year ago

While using topoplot() function, I get an error that mne.viz.plot_topomap() does not have some parameters (vmin and vmax, instead it only has a vlim parameter which takes a tuple of the two limits). I solved this by updating the function parameters as they are on the mne documentation. I suppose the mne library was updated, but the current yasa version uses the old version of men. Also when passing the kwargs arguments mne says that there is no show_names keyword argument.

packages versions:

yasa = 0.6.3
numpy =  1.23.5
mne = 1.3.1
scipy = 1.10.1
Python = 3.10.9
raphaelvallat commented 1 year ago

Hi @k0ruy,

Apologies for the late response. This is a known issue that has been fixed in the development version of YASA (#119). This will be released in the main (stable) version of YASA within the next weeks or months.

Thanks, Raphael

sjg2203 commented 1 year ago

Hi @raphaelvallat,

Any update/ETA on this feature? I was using this feature and am now facing the same issue where I can't get those topoplots.

Hi @k0ruy,

Apologies for the late response. This is a known issue that has been fixed in the development version of YASA (#119). This will be released in the main (stable) version of YASA within the next weeks or months.

Thanks, Raphael

raphaelvallat commented 11 months ago

Hi @sjg2203,

I'm aiming to release a new version of YASA during the winter vacation. For now, you can simply clone/fork YASA's source code and install directly from the master branch (python setup.py install).

raphaelvallat commented 10 months ago

Just released a new version of YASA that includes the fix: https://github.com/raphaelvallat/yasa/releases/tag/v0.6.4