margin and padding for View - Githubissues

raphamorim / react-ape

🦍• React Renderer to build UI interfaces using canvas/WebGL (TV and Hardware-Accelerated GPU development based)

https://raphamorim.io/react-ape/

MIT License

1.57k stars 48 forks source link

margin and padding for View #118

Open raphamorim opened 2 years ago

raphamorim commented 2 years ago

Implementation of margin and padding for existent elements

Harshalyadav commented 2 years ago

May, I take this issue?

raphamorim commented 2 years ago

For sure, feel free to take it @Harshalyadav but please start with one, breaking in three PRs: image, text, view (the order you take doesn’t matter)

raphamorim commented 2 years ago

@Harshalyadav I have broken into smaller issues (View, Text and Image). Later let me know which one want to work on, so I can assign the issue to you :)

Harshalyadav commented 2 years ago

Could you give me more info about this issue?

raphamorim commented 2 years ago

Yes, so the goal is to have the Style Props working for View. Both style props, margin and padding, follow React Native same directives and the work it works. Which is inspired by the way it works on CSS in Web browsers (https://blog.hubspot.com/website/css-margin-vs-padding).

Margin style prop definition: https://reactnative.dev/docs/layout-props#margin
Padding style prop definition: https://reactnative.dev/docs/layout-props#padding

AAYUSH-droid commented 2 years ago

hey u distributed this issue among #118 #119 #120?

raphamorim commented 2 years ago

yup @AAYUSH-droid

Harshalyadav commented 2 years ago

@raphamorim, Thank you.