Components: <Button/> - Githubissues

raphamorim / react-ape

🦍• React Renderer to build UI interfaces using canvas/WebGL (TV and Hardware-Accelerated GPU development based)

https://raphamorim.io/react-ape/

MIT License

1.57k stars 48 forks source link

Components: <Button/> #40

Open raphamorim opened 4 years ago

raphamorim commented 4 years ago

Reference: https://facebook.github.io/react-native/docs/button

Description: Implement an initial version of Button component on React Ape renderer using Canvas.

AC: Consider using it on devices like TV and portable games.

hayanisaid commented 2 years ago

@raphamorim I can take a look at this issue!

raphamorim commented 2 years ago

Sounds good, thank you @hayanisaid 👍 (Just a FYI: I am working in parallel in the navigation API)

hayanisaid commented 2 years ago

@raphamorim I have some questions about the Button component:

Should it add onPress, onClick, onFocus, onBluras props all together, or just enable an event based on the platform, but we don't have the Platform module yet.
I'm trying to make the button have an auto-layout, but I need to rely on the parentLayout {width,height} to got that done, do you know how this can be implemented? since the Flexbox is not implemented yet?

hayanisaid commented 2 years ago

Also, should I create another PR for the EventsHandling?

raphamorim commented 2 years ago

I think for now let's start with small changes (will be better to review later), so would recommend start the onClick and be layout-dummy, for example: maybe render as similar behaviour as a Text, reading View parentLayout and rendering anywhere inside there