search

raphamorim / react-tv

[ Unmaintained due to raphamorim/react-ape ] React Renderer for low memory applications
https://www.npmjs.com/package/react-tv
MIT License
2.01k stars 148 forks source link

Emulator.app file not found #125

Open DarryllRobinson opened 6 years ago

DarryllRobinson commented 6 years ago

The current version seems to be hard-coded to look for an older Emulator:

Up Emulator... The file /opt/webOS_TV_SDK/CLI/bin/../../Emulator/v3.0.0/LG_webOS_TV_Emulator_RCU.app does not exist.

I've tried looking for the config so I can point it to the newer version (Emulator v4.0.0) but couldn't find anything. What can I do to resolve the issue? I can't deploy any files until I get it sorted.

raphamorim commented 6 years ago

Hi @DarryllRobinson, did you installed the SDK? look if it can help in something -> https://medium.com/@raphamorim/developing-for-tvs-with-react-tv-b5b5204964ef

DarryllRobinson commented 6 years ago

Hi

Yes, I have installed the SDK. I can get the Emulator up by clicking on the app file but not through the yarn command. It looks for the Emulator file in the wrong location: v3.0.0 instead of the newer v4.0.0.

raphamorim commented 6 years ago

Hmm, yeah. You're right @DarryllRobinson. I'll make a fix for it til' Friday.

DarryllRobinson commented 6 years ago

Thanks a lot - much appreciated!

DarryllRobinson commented 6 years ago

Hi @raphamorim. Have you had a chance to update the version yet?

raphamorim commented 6 years ago

Hi @DarryllRobinson sorry for the delay 😢

So, I've released 0.4.1, now you can set version on env using WEBOS_CLI_TV_VERSION variable. I know it's not the best solution, but most part of this code will go to trash when all commands migrate to node-webos (https://github.com/react-tv/node-webos)

DarryllRobinson commented 6 years ago

Thank you very much, @raphamorim. The react-tv command can't be found which also prevents the app from working:

/bin/sh: react-tv: command not found error Command failed with exit code 127.

I'm sorry to keep bugging you - I know you're working hard on creating something great for all of us. Is there possibly something I should change in the package.json? It currently states:

"start": "yarn build && react-tv run-webos" --> it's the second bit that causes the problem.

Should I migrate to node-webos now instead? Or is it still in progress?

DarryllRobinson commented 6 years ago

I rewrote the script to react-tv-cli and it works now. I also had to change the run.js file as it didn't pick up the ENV properly but I got it working.

Thank you again.

raphamorim commented 6 years ago

No @DarryllRobinson, I'm sorry about that. Do you mind to send a PR with your changes, so we can fix other people too.

DarryllRobinson commented 6 years ago

Hi @raphamorim. I'm very happy to help where I can but I'm new to this game so I don't know what you mean by a PR, sorry. Instead, I can show you the code I used if that will help.

I changed the /node_modules/react-tv-cli/scripts/webos/run.js to explicitly set the version like so:

//const version = (webOSTVVersion) ?v${webOSTVVersion}: 'v3.0.0'; const version = 'v4.0.0';

The package.json I changed from what I read in your article. The script there says:

"start": "yarn build-prod && react-tv run-webos",

so I changed it to:

"start": "yarn build-prod && react-tv-cli run-webos",

If there is anything else I can help you with, please let me know.