search

raphamorim / react-tv

[ Unmaintained due to raphamorim/react-ape ] React Renderer for low memory applications
https://www.npmjs.com/package/react-tv
MIT License
2.01k stars 148 forks source link

Set correct emulator version #153

Closed Aspect26 closed 3 years ago

Aspect26 commented 3 years ago

In https://github.com/raphamorim/react-tv/blob/master/packages/react-tv-cli/scripts/webos/run.js#L107 there is a hardwired version in the output string, it would be better if it was taken from the environment.

Also in https://github.com/raphamorim/react-tv/blob/e2e97a5ee2f8c0e8fc1b008eea3df39f3870dd80/packages/react-tv-cli/scripts/webos/run.js#L9 the version defaults to v3.0.0 if not specified in env. I think it would be better to change it to v5.0.0 since its the current version.

raphamorim commented 3 years ago

Closed and fixed by #156