search

raphamorim / react-tv

[ Unmaintained due to raphamorim/react-ape ] React Renderer for low memory applications
https://www.npmjs.com/package/react-tv
MIT License
2.01k stars 148 forks source link

Add fs.readdir to avoid crash when SDK path contains empty spaces #155

Closed matheusmonte closed 3 years ago

matheusmonte commented 3 years ago

As response to this issue #154

I added fs.readdir to avoid empty space cause a wrong path reader. I have limited test environment once I'm on OSx and not on Ubuntu as reported.

It must solve issue, but before merge, I recommend to test in a ubuntu test environment.

Aspect26 commented 3 years ago

maybe I understood something wrong, but this does not work because fs.readdir returns promise of string array (files in the given directory). So even if there was async/await, it would not return the whole path.

I made a fix in my fork, Ill create a PR and you can look at it if it is ok :)

matheusmonte commented 3 years ago

Hey @Aspect26 DO you open the PR for this issue?

Aspect26 commented 3 years ago

hi. yes! iits here #156

raphamorim commented 3 years ago

Closed in favor #156