raphamorim / rio

A hardware-accelerated GPU terminal emulator focusing to run in desktops and browsers.
https://raphamorim.io/rio
MIT License
3.91k stars 125 forks source link

"Regression" in italics handling on v0.0.19 #234

Closed ralgozino closed 1 year ago

ralgozino commented 1 year ago

On v0.0.18 I get proper italics for example for comments in VIM instead of just the font hinted (with Victor Mono).

Here's a screenshot with v0.0.18 on the left and v0.0.19 on the right, notice the difference in the comments' font rendering:

image

I'd prefer the behaviour that was on 0.0.18.

Here's my config in case is just a configuration issue:

blinking-cursor = true

[window]
width = 1200
height = 900

[fonts]
family = "Victor Mono"

[fonts.regular]
family = "Victor Mono"
style = "regular"
weight = 400

[fonts.bold]
family = "Victor Mono"
style = "bold"
weight = 800

[fonts.italic]
family = "Victor Mono"
style = "italic"
weight = 400

[fonts.bold-italic]
family = "Victor Mono"
style = "bold italic"
weight = 800

[navigation]
mode = "NativeTab"

[developer]
log-level = "INFO"
raphamorim commented 1 year ago

@ralgozino can you try again with the logs? (I've added an error log to whenever the font is not found in the main)

raphamorim commented 1 year ago

Ah actually I misunderstood the issue, the font is found but is rendering differently right?

raphamorim commented 1 year ago

For me is working as before 🤔

Screenshot 2023-09-23 at 23 43 20
raphamorim commented 1 year ago

My config Screenshot 2023-09-23 at 23 44 27

ralgozino commented 1 year ago

Hi @raphamorim

Sorry for the delayed answer, I've just tested with 0.0.22, rio uses the oblique style instead of italics in my case:

image

Notice that also underline is not working anymore.

Doing some tests, I found that if I delete the oblique otf font file from my system, then rio finds the italic and uses it.

raphamorim commented 1 year ago

Thank you @ralgozino ,

VictorMono has been on top 3 "weird" behaviour with rio, underline with fira code:

Screenshot 2023-10-03 at 18 17 14

I am rewriting sugarloaf to stretch/reposition glyphs should fix VictorMono underline and other fonts that have bigger/smaller stroke of underline.

Will be closing this issue, but will be keeping an eye on it. I can't reproduce tbh, I have oblique and italic of victor mono and it always match up with italic.