raphamorim / rio

A hardware-accelerated GPU terminal emulator focusing to run in desktops and browsers.
https://raphamorim.io/rio
MIT License
3.51k stars 111 forks source link

[Bug] Tab indicator doesn't disappear #493

Closed MrPandir closed 1 month ago

MrPandir commented 5 months ago

If you delete the first tab, the terminal automatically switches to the second tab, but the tab indicators are not updated. If you create a new tab and delete it (it will be the second one), the tab indicators will disappear. I expect the same behavior when deleting the first tab.

Video

https://github.com/raphamorim/rio/assets/137798474/0c60720e-6253-45b7-917b-511ac36e34b8

Additional Information

Rio Version: 0.0.36 OS: macOS 14.4 Config:

cursor = '▇'
blinking-cursor = false
confirm-before-quit = false
[navigation]
mode = "CollapsedTab"
raphamorim commented 5 months ago

Hey @MrPandir thanks for the issue,

So to confirm if I understood it correctly, what you mean is that tab should be there and not disappear even if is the last one?

MrPandir commented 5 months ago

So to confirm if I understood it correctly, what you mean is that tab should be there and not disappear even if is the last one?

No. The display of tab indicators should always disappear when there is only one tab. This is how it is implemented in other terminals.

The bug is that if you delete the first tab (⌘ + 1), it will not be reflected in the indicators. So if you have 4 tabs:

* * * *
^

You delete the first tab by pressing ⌘ + w or exit in the terminal. Now we have 3 tabs. The terminal will automatically switch to the next tab, but this will not update the indicators. The indicators will still be four, which is false:

* * * *
^

When it is expected to be displayed as:

* * *
^
raphamorim commented 1 month ago

@MrPandir can you test it with latest main?

MrPandir commented 1 month ago

@MrPandir can you test it with latest main?

Yes, this was fixed in main. 😃

raphamorim commented 1 month ago

Great!! 😊