search

raphamorim / rio

A hardware-accelerated GPU terminal emulator focusing to run in desktops and browsers.
https://raphamorim.io/rio
MIT License
3.21k stars 103 forks source link

[Bug] The `[colors]` option does not override theme colors. #494

Closed MrPandir closed 2 months ago

MrPandir commented 2 months ago

As the documentation states:

Defining colors in the configuration file will override any colors set in the theme if you're using a theme.

The background should be white as specified by background = '#FFFFFF'

Screenshots

Screenshot 2024-04-24 at 16 19 40

Additional Information

Rio Version: 0.0.36 OS: macOS 14.4 Config:

theme = "Dark Pastel"
confirm-before-quit = false
[navigation]
mode = "CollapsedTab"
[colors]
background = '#FFFFFF'
raphamorim commented 2 months ago

Hey @MrPandir thanks for the issue,

Could you try the same configuration without theme = "Dark Pastel"?

MrPandir commented 2 months ago

Could you try the same configuration without theme = "Dark Pastel"?

If the theme is not set, this works correctly.

However, when the theme setting is set, it does not override the theme colors, which is the issue.

raphamorim commented 2 months ago

Ahhh very good catch. This was removed and I forgot to update the docs.

Just did a commit updating it, for small changes you should update theme file itself.