raphamorim / rio

A hardware-accelerated GPU terminal emulator focusing to run in desktops and browsers.
https://raphamorim.io/rio
MIT License
3.2k stars 103 forks source link

Odd background transparency on macOS (Intel) #514

Closed grantholle closed 3 weeks ago

grantholle commented 1 month ago

Screenshot 2024-05-24 at 8 45 15 AM

The background doesn't span the entire window, leaving it hard to know where the window actually is since it's transparent. Here's my config:

editor = 'code'
line-height = 1.2
cursor='|'
padding-x = 15
working_dir = "/Users/grant"

[window]
foreground-opacity = 1.0
background-opacity = 0.8

[fonts]
size = 18
family='JetBrains Mono'

I can fix the issue by setting background-opacity = 1.0, quitting and restarting. However, as soon as I add any other value for background-opacity, the issue reoccurs.

raphamorim commented 1 month ago

Hey @grantholle thanks for the issue, which version is that?

grantholle commented 1 month ago

Sorry forgot to mention that, 0.0.39

raphamorim commented 1 month ago

No worries! I actually can reproduce and I assume is related I've made in the past 2 versions. Could you confirm if you can reproduce it in the version 0.0.37?

zmb3 commented 1 month ago

I can confirm I do see this issue on macOS (Apple Silicon) on version 0.0.39 but I do not see it on 0.0.37.

raphamorim commented 1 month ago

Thank you @zmb3 for checking it! Yes, I think is related to some changes I've made on opacity on the last 2 versions. Will release a fix it during this week

TitanNano commented 1 month ago

for me the bottom of the window is transparent.

image

On a MacBook Pro M1 Pro

raphamorim commented 1 month ago

Yea, the old issue is "partially" fixed tbh. I cannot rollback for the changes that was before because was "buggy" not use the background color straight. However, if you don't have padding enabled should be working ok like @TitanNano screenshot, but with the padding enabled things get weird.

I am close to wrap up a release candidate to 0.1.0, where this issue should be fixed for padding on as well 👌

raphamorim commented 3 weeks ago

This issue should not be able to reproduce with the latest release (v0.1.0), closing this issue for now. In case find anything odd we can reopen or create a new issue.