search

raphamorim / rio

A hardware-accelerated GPU terminal emulator focusing to run in desktops and browsers.
https://raphamorim.io/rio
MIT License
3.51k stars 111 forks source link

[Bug] Rendering problem with TUIs using cursor movement control sequences in rio (v0.1.1+) #574

Closed timon-schelling closed 1 month ago

timon-schelling commented 2 months ago

Description

Starting from version v0.1.1 rio encounters an issue with rendering Text User Interfaces (TUIs) that utilize cursor movement control sequences to redraw parts of the terminal.

Steps to Reproduce

Demonstration

https://github.com/user-attachments/assets/7c0a1009-105e-44fc-b51a-f8fbebebe6f2

Expected Behavior

The terminal should correctly render TUIs without graphical glitches when using cursor movement control sequences.

Additional Information

I plan to investigate this further when I have the time. Any insights or assistance from the community would be greatly appreciated.

Thank you for your attention. Thanks for creating rio :)

MrPandir commented 2 months ago

This is probably the same issue as https://github.com/raphamorim/rio/issues/534. It should be fixed in 0.1.2.

timon-schelling commented 2 months ago

Not the same bug as in #534 and still present in v0.1.2.

Tested with the flake in this repo:

nix run github:raphamorim/rio#rio -- -e nix run nixpkgs#btop

Version is 0.1.2:

❯ nix run github:raphamorim/rio#rio -- -V
rioterm 0.1.2
raphamorim commented 1 month ago

I think pushed a proper fix for it, could you test latest main?

Screenshot 2024-08-07 at 23 11 54
timon-schelling commented 1 month ago

This issue seems to be fixed but some parts of my font are now broken with d86ec56ab17629d4add2f75c50d8e676f7e9d0c4.

In this video on the left d86ec56ab17629d4add2f75c50d8e676f7e9d0c4 on the right v0.0.39:

https://github.com/user-attachments/assets/9b76e413-3db3-4302-b528-e25edfd7b62c

Environment of both processes is identical. Did font loading change in some way?

timon-schelling commented 1 month ago

@raphamorim I should properly create a new issue for this?

raphamorim commented 1 month ago

yes please create another issue @timon-schelling also, are you using a font different than the default (you can write it down in the new issue)

thank you!