Open Kreijstal opened 1 week ago
raphamorim
commented
1 week ago thanks for the issue @Kreijstal , looks is like a linking problem. I will mark it to take a look! btw regarding your comment in the sixel PR https://github.com/raphamorim/rio/pull/625, did you mean that isn't working for you on Windows?
Kreijstal
commented
1 week ago correct, sixel is not working for me on windows, but I built it using msys2 maybe that was the problem?, wezterm and mintty have no problems with it.
$ lsix
Error: Your terminal does not report having sixel graphics support.
Please use a sixel capable terminal, such as xterm -ti vt340, or
ask your terminal manufacturer to add sixel support.
You may test your terminal by viewing a single image, like so:
convert foo.jpg -geometry 800x480 sixel:-
If your terminal actually does support sixel, please file a bug
report at http://github.com/hackerb9/lsix/issuesah we are together on it then 👍 🤝
I know why isn't recognizing it straight, will do a fix for it during this week
raphamorim
commented
1 week ago the command itself does work though, is just seq report that's missing
raphamorim
commented
1 week ago btw regarding the original issue you posted, I think might be a good idea add msys2 builds in the CI for testing as well https://www.msys2.org/docs/ci/
Kreijstal
commented
1 week ago I think this is kind of a draft of how to do it in CI for the 3 enviroments msys2 support
windows-build:
strategy:
matrix:
sys: [MINGW64, UCRT64, CLANG64]
runs-on: windows-latest
steps:
- uses: actions/checkout@v4
- name: Setup MSYS2
uses: msys2/setup-msys2@v2
with:
msystem: ${{ matrix.sys }}
update: true
install: base-devel git
pacboy: >-
rust:p
cc:p
pkgconf:p
cmake:p
freetype:p
python:p
fontconfig:p
- name: Run make
shell: msys2 {0}
run: cargo build@Kreijstal would you like to send a PR with the CI support for testing?
I will take a look on the build in parallel, once is fixed then we can merge the PR. What you think?
raphamorim
commented
1 week ago @Kreijstal i tried to build with release flags using cygwin. It did work for me, wonder if i am doing something off
Kreijstal
commented
1 week ago @Kreijstal i tried to build with release flags using cygwin. It did work for me, wonder if i am doing something off
that can't be possible as cygwin has no rust compiler (okay, someone managed to do it but it's very niche), you are right that msys2 is "essentially" cygwin, but you can also run native windows programs, in that case rust:p is a "native" windows application, not a cygwin/msys application.
I think of msys2 as cygwin except you can cross compile from cygwin to native windows builds, however most of our environment is windows, rust:p is just an abreviation for ${MINGW_PACKAGE_PREFIX}-rust, https://packages.msys2.org/package/mingw-w64-x86_64-rust. So my question to you is if you are using rust from msys2 or rust from rustup?
I know this is a bit complicated and it took me a while to understand, but after a while it makes a lot of sense. It's just one of the very few ways to build software without using Visual Studio on Windows.
this is with the msys2 rust toolchain only --release builds are affected, --debug builds build fine!