search

raphamorim / rio

A hardware-accelerated GPU terminal emulator focusing to run in desktops and browsers.
https://raphamorim.io/rio
MIT License
3.47k stars 110 forks source link

Windows default editor shouldn't be "vi" #677

Open milnak opened 5 hours ago

milnak commented 5 hours ago

"vi" isn't installed by default on windows.

# Editor
#
# Default editor is "vi".
#
# Whenever the key binding `OpenConfigEditor` is triggered it will
# use the value of the editor along with the rio configuration path.
# [editor]
# program = "vi"
# args = []

This should probably be notepad as a default on Windows.

raphamorim commented 5 hours ago

Thank you for the issue @milnak ! I agree, is this something you would like to contribute?

milnak commented 4 hours ago

I tried changing this to notepad on windows, and it appears that rio is still looking all over my path for vi?

C:\Users\jeffm\scoop\apps\rio\current\vi C:\Users\jeffm\AppData\Local\rio\config.toml   NAME INVALID
C:\Users\jeffm\scoop\apps\rio\0.1.15\vi C:\Users\jeffm\AppData\Local\rio\config.toml    NAME INVALID
C:\WINDOWS\SYSTEM32\vi C:\Users\jeffm\AppData\Local\rio\config.toml NAME INVALID
C:\WINDOWS\system\vi C:\Users\jeffm\AppData\Local\rio\config.toml   NAME INVALID
C:\WINDOWS\vi C:\Users\jeffm\AppData\Local\rio\config.toml  NAME INVALID
C:\Windows\system32\vi C:\Users\jeffm\AppData\Local\rio\config.toml NAME INVALID
C:\Windows\vi C:\Users\jeffm\AppData\Local\rio\config.toml  NAME INVALID
C:\Windows\System32\Wbem\vi C:\Users\jeffm\AppData\Local\rio\config.toml    NAME INVALID
C:\Windows\System32\WindowsPowerShell\v1.0\vi C:\Users\jeffm\AppData\Local\rio\config.toml  NAME INVALID
C:\Windows\System32\OpenSSH\vi C:\Users\jeffm\AppData\Local\rio\config.toml NAME INVALID
C:\Program Files\dotnet\vi C:\Users\jeffm\AppData\Local\rio\config.toml NAME INVALID
C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common\vi C:\Users\jeffm\AppData\Local\rio\config.toml  NAME INVALID
C:\Program Files\NVIDIA Corporation\NVIDIA NvDLISR\vi C:\Users\jeffm\AppData\Local\rio\config.toml  NAME INVALID
C:\Program Files (x86)\Common Files\Propellerhead Software\ReWire\vi C:\Users\jeffm\AppData\Local\rio\config.toml   NAME INVALID
C:\Program Files\Common Files\Propellerhead Software\ReWire\vi C:\Users\jeffm\AppData\Local\rio\config.toml NAME INVALID
C:\Program Files\Meld\vi C:\Users\jeffm\AppData\Local\rio\config.toml   NAME INVALID
C:\Program Files\PowerShell\7\vi C:\Users\jeffm\AppData\Local\rio\config.toml   NAME INVALID
C:\Users\jeffm\.pyenv\pyenv-win\bin\vi C:\Users\jeffm\AppData\Local\rio\config.toml NAME INVALID
C:\Users\jeffm\.pyenv\pyenv-win\shims\vi C:\Users\jeffm\AppData\Local\rio\config.toml   NAME INVALID
C:\Users\jeffm\scoop\apps\openjdk\current\bin\vi C:\Users\jeffm\AppData\Local\rio\config.toml   NAME INVALID
C:\Users\jeffm\scoop\apps\anaconda3\current\App\Scripts\vi C:\Users\jeffm\AppData\Local\rio\config.toml NAME INVALID
C:\Program Files\Meld\vi C:\Users\jeffm\AppData\Local\rio\config.toml   NAME INVALID
C:\Users\jeffm\scoop\apps\gsudo\current\vi C:\Users\jeffm\AppData\Local\rio\config.toml NAME INVALID
C:\Users\jeffm\scoop\shims\vi C:\Users\jeffm\AppData\Local\rio\config.toml  NAME INVALID
E:\bin\vi C:\Users\jeffm\AppData\Local\rio\config.toml  NAME INVALID
C:\Users\jeffm\AppData\Local\Microsoft\WindowsApps\vi C:\Users\jeffm\AppData\Local\rio\config.toml  NAME INVALID
C:\Program Files\7-Zip\vi C:\Users\jeffm\AppData\Local\rio\config.toml  NAME INVALID
C:\Users\jeffm\AppData\Local\Microsoft\WindowsApps\vi C:\Users\jeffm\AppData\Local\rio\config.toml  NAME INVALID
C:\Users\jeffm\AppData\Local\Programs\Microsoft VS Code\bin\vi C:\Users\jeffm\AppData\Local\rio\config.toml NAME INVALID
C:\Users\jeffm\.dotnet\tools\vi C:\Users\jeffm\AppData\Local\rio\config.toml    NAME INVALID