search

raphamorim / rio

A hardware-accelerated GPU terminal emulator focusing to run in desktops and browsers.
https://raphamorim.io/rio
MIT License
3.48k stars 111 forks source link

Can't close window by command+w when navigation mode is not NativeTab #683

Open shmn7iii opened 5 hours ago

shmn7iii commented 5 hours ago

I want to close the last tab(= window) with command+w as I do with other tabs. When the navigation mode is NativeTab, we can do this. I've confirmed locally that this can be done by removing this if-statement. If so, I want to contribute! (though, I guess I'll just be deleting a line. 😂)

But, actually, I'm not familiar with macOS and Rust development. Let me know if there's any reason why it's limited to the NativeTab mode.

Thank you.

raphamorim commented 5 hours ago

Ah very good you opened this issue! I am actually working on this for next version, it should close for all navigations and I've added a question if you want to really close rio.

Screenshot 2024-09-22 at 17 53 04
shmn7iii commented 4 hours ago

@raphamorim Wow! Looks so good! You mean you've already been working on implementing this (already deleted the if-statement), right? Then I'll wait for the next version, and looking forward to it!

raphamorim commented 4 hours ago

You mean you've already been working on implementing this (already deleted the if-statement), right? Then I'll wait for the next version, and looking forward to it!

Yes!! Should be same behaviour as native tabs 🙏

shmn7iii commented 4 hours ago

Got it! Thank you so much :)