search

raphamorim / rio

A hardware-accelerated GPU terminal emulator focusing to run in desktops and browsers.
https://raphamorim.io/rio
MIT License
4.07k stars 136 forks source link

Add ability to specify platform specific shell. #765

Closed crispy-strawberry closed 1 week ago

crispy-strawberry commented 2 weeks ago

Closes #755

melroy89 commented 2 weeks ago

Also add it to the example config file & documentation page?

raphamorim commented 2 weeks ago

Thanks for the PR @crispy-strawberry !! I think there's just one thing, not only Shell should be under platform but also Window (https://raphamorim.io/rio/docs/config/window) and Navigation (https://raphamorim.io/rio/docs/config/navigation).

So probably the function you did get_shell might not be the best approach.

I would actually add a function on config called overwrite_based_on_platform here: https://github.com/raphamorim/rio/blob/main/frontends/rioterm/src/main.rs#L149-L181

This function would check if shell, window and navigation aren't none, if they are not then override each one.

What do you think?

raphamorim commented 1 week ago

Added your changes and implemented the suggestion on cfbb148e 🙏

crispy-strawberry commented 1 week ago

@raphamorim Sorry I'm a little busy with life atm and couldn't update it 😢

raphamorim commented 1 week ago

No worrieeeeees at all!!! @crispy-strawberry <3

raphamorim commented 1 week ago

I love the fact you started it, thank you for the contribution!