search

raphamorim / rio

A hardware-accelerated GPU terminal emulator focusing to run in desktops and browsers.
https://raphamorim.io/rio
MIT License
4.07k stars 136 forks source link

Grey triangle in the titlebar #778

Closed hunger closed 1 week ago

hunger commented 1 week ago

Whenever I start rio I get a small grey triangle in the title bar. See screenshot:

screenshot

This triangle stays in place independent of what I do.

OS: Linux (fedora silverblue 41) Configuration: ~/.config/rio does not exist Installation method: cargo install rioterm terminfo: rio is installed and reported by infocmp GPU: Interl builtin and ATI on a different machine

hunger commented 1 week ago

Happens with master, too.

hunger commented 1 week ago

The grey triangle is the default RIO_TITLE. It never gets updated.

This is due to fn update_titles() in frontends/rioterm/src/context/mod.rs never trying to update since self.config.is_native is false at all times.

That is because that is hard-coded to false in rio-backend/src/config/navigation.rs.

hunger commented 1 week ago

I would argue that is-native is not the right condition to update the window title and would suggest to just remove that condition from the update_titles function. The PR changes that.

baalajimaestro commented 6 days ago

Is this fixed only on windows/macos? I seem to have this issue yet on linux

hunger commented 6 days ago

This works for me in 0.2.1 on Linux.

baalajimaestro commented 6 days ago

i use swaywm, and with 0.2.1, i see only this. whatever command i type doesnt seem to budge.

image

baalajimaestro commented 1 day ago

And i figured out another niche case. incase you wanted the window titles without navigation automation, add this to the navigation color automation section, and window titles would work.

color-automation = [{ program = "null", color = "#FF0000" },]