raphamorim / rio

A hardware-accelerated GPU terminal emulator focusing to run in desktops and browsers.
https://raphamorim.io/rio
MIT License
3.63k stars 115 forks source link

Background colors are not matching when using ranger #92

Closed raphamorim closed 1 year ago

raphamorim commented 1 year ago

Kitty and Alacritty:

Screenshot 2023-06-12 at 23 05 32 Screenshot 2023-06-12 at 23 05 45

Rio:

Screenshot 2023-06-12 at 23 06 00
ehjmx commented 1 year ago

For me aerc and joe's own editor show the same behavior.

Joe in Alacritty Alacritty

Joe in Rio Rio_Terminal

macOS 13.4 Rio Version 0.0.61

The latest Canary build from 8 hours ago not only changed the Icon but it also broke themes support here on my Mac. In 0.0.61 themes support works so the config file is correct.

raphamorim commented 1 year ago

@ehjmx the latest canary introduced breaking changes in the configuration file. The new format https://raphamorim.io/rio/docs/#configuration-file (I will write more about it in the changelog of 0.0.7)

Thanks for letting me know about the joe case, I will take a look on it as well

ehjmx commented 1 year ago

@raphamorim I did a test with the new configuration format and themes now work again. I especially like that I can now set another shell as zsh as the default shell that Rio launches.

However there is display glitch when I switch to block for the cursor.

Cursor underscore looks like this cursor_as_underscore

Cursor as block the block uses two lines cursor_as_block

Shall I file a new issue for this?

Thanks for rio. I like using it and I'm thinking about using as my new default terminal but at the moment the heavy development and the changes in the configuration file etc are sort of a deal breaker in my stable work environment

raphamorim commented 1 year ago

I did a test with the new configuration format and themes now work again.

That's great.

Shall I file a new issue for this?

Yes, please file a new issue for that @ehjmx . Thank you 🙏

raphamorim commented 1 year ago

Fixed in c6f380f

Screenshot 2023-07-05 at 18 55 58 Screenshot 2023-07-05 at 18 56 20