add one more config property and update it

raphamorim / waterfall.js

Tired of use creepy hacks or heavy ways to get a Grid based on Pinterest?

http://raphamorim.io/waterfall.js/

540 stars 70 forks source link

add one more config property and update it #28

Closed Cecilina closed 8 years ago

Cecilina commented 8 years ago

With default 3, I got following display default_3 After update the code. Here is the results. with_additional_property

Thanks!

raphamorim commented 8 years ago

I see, Predefine grid can be a option, what do you think @israelst?

israelst commented 8 years ago

@Cecilina Hello!

I didn't get why smallerColumnLen needs to be a parameter, given that we are already calculating the quantity of elements that fit in a row. Could you clarify it?

Thanks for you time.

israelst commented 8 years ago

@Cecilina, please take a look at #29. If it solves your problem we can merge it after your contribution at develop. What do you think?

israelst commented 8 years ago

@Cecilina, I'm closing it for now. Let me know if this PR doesn't solve your issue.

Thank you for your time.