raphendyr / gitlabhq

This fork contained implementation for PAM based login to Gitlab. It's left as archived as the feature was never merged.
MIT License
1 stars 1 forks source link

Doesn't work git neither over HTTP or over SSH #11

Closed xaionaro closed 10 years ago

xaionaro commented 10 years ago

Over SSH: works clone doesn't work push

Over HTTP: doesn't work clone and push

$ git push -u origin master error: src refspec master does not match any. error: failed to push some refs to 'gitlab@gitlab.ut.mephi.ru:xaionaro/test.git'

$ git clone https://gitlab.ut.mephi.ru/xaionaro/private.git Cloning into 'private'... Username for 'https://gitlab.ut.mephi.ru': xaionaro Password for 'https://xaionaro@gitlab.ut.mephi.ru': fatal: Authentication failed

xaionaro commented 10 years ago

Seems, that I got it work over HTTP. It's need to set password via Web-interface and use this password for clone/push.

raphendyr commented 10 years ago

I didn't validate https pam authentication. I did try to handle that, but as usual, didn't validate. SSH should work fine. Pam has nothing to do with that side. At least in our environment it works well.

I try to make https push/pull/auth work with 6.4 as eclipse users might need it.

xaionaro commented 10 years ago

I solved the problem with HTTP(s). I've modified my gitlab instance to save correct password hashes to DB while creating an user authenticated by PAM or LDAP.

Also I've solved problem with SSH. It was due to SSH connection multiplexing. It can be disabled on server side with:

Match User gitlab
        MaxSessions 1

in /etc/ssh/sshd_config.

raphendyr commented 10 years ago

Hmm.. I have to investigate the ssh problem some day. And I need to fix the password thing. The hole point is not to need gitlab passwords.

Thanks for the information :)

xaionaro commented 10 years ago

And I need to fix the password thing.

I can prepare a patch how I solved that issue. But I'm not a ruby programmer, so… :)

The hole point is not to need gitlab passwords.

What do you mean?

raphendyr commented 10 years ago

Any kind of patch is ok. I'm not ruby coder either, but I'm getting better ;)

Point about passwords, were that when using pam or ldap, there shouldn't be any need for gitlab internal password as pam/ldap back end would authenticate user in all cases..

raphendyr commented 10 years ago

HTTPS is fixed in 6-4-pam, well at least worked in my tests.

fixing commit: raphendyr/gitlabhq@c08c34c