search

raphink / moderntimeline

A timeline package for moderncv
77 stars 15 forks source link

Update moderntimeline.dtx #7

Closed Astrinus closed 9 years ago

Astrinus commented 9 years ago

Shaded entries have a first part not shaded.

raphink commented 9 years ago

Thank you and welcome to github!

Could you please describe what this does exactly (maybe with images) and if this changes the existing behaviour? On 17 Feb 2015 21:09, "Astrinus" notifications@github.com wrote:

Shaded entries have a first part not shaded.

You can view, comment on, or merge this pull request online at:

https://github.com/raphink/moderntimeline/pull/7 Commit Summary

  • Update moderntimeline.dtx

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/raphink/moderntimeline/pull/7.

raphink commented 9 years ago

Also, it seems that the change breaks the tests. See https://travis-ci.org/raphink/moderntimeline/builds/51128930 On 17 Feb 2015 21:22, "Raphaël Pinson" raphink@gmail.com wrote:

Thank you and welcome to github!

Could you please describe what this does exactly (maybe with images) and if this changes the existing behaviour? On 17 Feb 2015 21:09, "Astrinus" notifications@github.com wrote:

Shaded entries have a first part not shaded.

You can view, comment on, or merge this pull request online at:

https://github.com/raphink/moderntimeline/pull/7 Commit Summary

  • Update moderntimeline.dtx

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/raphink/moderntimeline/pull/7.

Astrinus commented 9 years ago

It doesn't change the existing behaviour. It simply changes slightly the appearance of the bars. schermata1 The shading goes for 40% to 100% of the bar length instead of 0%-100%, in some cases (especially if the base color is dark) it is rendered better.

raphink commented 9 years ago

OK. Maybe this 0.4 value could become a parameter, so it would be backwards compatible and allow users to fine tube the rendering.

Astrinus commented 9 years ago

I have created a new macro, \tlsetnotshadedfraction, and updated my branch. This is the first time I use Git, so I don't know if I should make another pull request.

raphink commented 9 years ago

That looks good, thanks. Now we just need to figure out why the Travis build is failing...

Are you able to run the following successfully?

$  make moderntimeline.pdf && make check

Congrats on starting with git :+1:

Astrinus commented 9 years ago

Well... I didn't know there was a CheckSum line in the .dtx :-$

Astrinus commented 9 years ago

And I didn't know about pdf_spec.rb... By the way, one of the failures pertains the last check: I have commented it out, but I don't know Ruby or how rspec works.

Astrinus commented 9 years ago

Yes, it adds a new page (description of \tlsetnoshadedfraction causes text to overflow) and I don't know why the title error arises, since the file looks good being opened with Okular...

raphink commented 9 years ago

Makes sense for the number of pages. However the title issue is strange. I'll have to try it and see why it fails.

raphink commented 9 years ago

Merged as 7299b89aab4b8e8fe2486ac0ae52b609b261ae07, thank you.

raphink commented 9 years ago

Released as 0.8