search

raphlinus / font-rs

Apache License 2.0
753 stars 49 forks source link

Replacing unsupported (by MSVC) cast with intrinsic. #18

Closed mason-bially closed 6 years ago

mason-bially commented 6 years ago

This cast is not supported by MSVC, however the intrinsic is. The mirror intrinsic (_mm_castps_si128) is already being used so this intrinsic should be supported by anything that was already able to compile this.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

mason-bially commented 6 years ago

I signed it!

On Thu, Sep 28, 2017 at 9:44 PM, googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google/font-rs/pull/18#issuecomment-333029670, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBfHGjHFugiGTIM-hcEM1pXsAZuQm58ks5snHWsgaJpZM4PoMVz .

googlebot commented 6 years ago

CLAs look good, thanks!

mason-bially commented 6 years ago

Probably should have checked first (fixes #14). Looks like a dead project.

raphlinus commented 6 years ago

Thanks for the fix! It is true I'm not actively working on font-rs anymore, but happy to keep it running.

mason-bially commented 6 years ago

Thank you! I was just demoralized because all the open pull requests were this issue.