Added regression tests for glyph lookup.

raphlinus / font-rs

Apache License 2.0

755 stars 49 forks source link

Added regression tests for glyph lookup. #35

Closed golddranks closed 5 years ago

golddranks commented 5 years ago

I thought that more tests can't hurt, so I made some regression tests for the recent fixes. This includes multiple cases that used to fail.

raphlinus commented 5 years ago

This looks cool! @rtsuk do you want to do a quick sanity check that the licensing metadata is suitable? It seems to check out in my quick review, but I think it makes sense to get another pair of eyes on it.

rtsuk commented 5 years ago

Looks fine to me, but I won't know how Fuchsia feels about it until we next update font-rs. If it turns into a problem then we can figure it out.

rtsuk commented 5 years ago

Also, thanks again @golddranks for cleaning this up!

raphlinus commented 5 years ago

Thanks!