search

raphlinus / font-rs

Apache License 2.0
753 stars 49 forks source link

hhea table #37

Open Orycterope opened 5 years ago

Orycterope commented 5 years ago

Parsing the hhea table, to get some general information about the font :

As I understand it, this is needed to get the distance between two baselines (MaxAscent + MaxDescent + LineGap)

raphlinus commented 5 years ago

This looks pretty good, and I'm inclined to merge it. Before I do, I want to be sure you understand that HHEA is one of (at least) 3 sets of metrics tables. The vertical metrics page at Glyphs has lots more information on this.

Perhaps this means a change to doc comments or method names to emphasize that this is the HHEA value and not the definitive value for such metrics.

Orycterope commented 5 years ago

Thank you, your site was really instructive. I knew those values weren't definitive, but I didn't know it was this much of a mess. I'm adding doc comments right away !