raphlinus / ghilbert

Automatically exported from code.google.com/p/ghilbert
Apache License 2.0
48 stars 4 forks source link

Code Review for R45 #1

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Purpose of code changes on this branch:
To enable unification error messages to pinpoint the exact location in the 
input of the offending variable.  This is with an eye towards auto-correction 
in the future.

When reviewing my code changes, please focus on:

The change is pretty minor, but at the same time invasive, because there were 
so many instances of "typeof foo == 'string'" and "foo === bar".  The latter 
fails when foo is a String() and bar is a string; i.e. new String("foo") !== 
'foo', even though with only two equals it works.  I just changed all === to == 
and !== to !=, since I didn't see any reason why they should be using ===, and 
it seemed silly to be using == for strings and === for everything else.  Please 
let me know if there are subtle places in the code that rely on ===.

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by abliss on 6 Aug 2010 at 4:31

GoogleCodeExporter commented 9 years ago
I'm fairly sure this change got merged into master (git-speak for svn trunk) as 
part of the relatively recent updates. If not, feel free to reopen the bug. 
Thanks!

Original comment by r...@google.com on 15 Oct 2012 at 3:41