search

raphnet / vspcplay

vspcplay, a visual spc player
http://vspcplay.raphnet.net/
29 stars 4 forks source link

dev/makefile-mxe/use-info #18

Closed ProjectHSI closed 9 months ago

ProjectHSI commented 9 months ago

I forgot to swap out the warning command for the info command. I was using it for debugging.

Also the commit is just straight up weird, I think it had something to do with the fact Git wasn't configured to run with sudo which I did to try and diagnose the problem, Git was acting weird with signing.

Here's the error if you have any idea.

warning: command not found
error: gpg failed to sign the data
fatal: failed to write commit object
raphnet commented 9 months ago

I'm sorry, but could you redo this commit with a message that makes sense?

ProjectHSI commented 9 months ago

clarification: replace $(warning) with $(info) in makefile.mxe. Once again I just forgot to swap out $(warning) with $(info) when pushing. Is this enough or would you like the commit name to be clarified

raphnet commented 9 months ago

Sorry to be a pain, but I would like the project's commit history to be clean and understandable when I type git log. As things are now, my terminal will scroll several pages contents that has nothing to do with what the commit actually is about.

Could you prepare a new pull request with the same change, but with a normal commit message?

ProjectHSI commented 9 months ago

Closed to comply with the request.