Closed FelixMarxIBM closed 7 months ago
@raphw should I create an Issue for that or is a PR enough?
Thanks, I come across windows so rarely, great you could contribute this! I'll merge it obce the checks complete.
Hi @raphw I saw that the build failed here with the error
Error: /home/runner/work/byte-buddy/byte-buddy/byte-buddy-agent/src/main/java/net/bytebuddy/agent/VirtualMachine.java:1083: @return tag should be present and have description. [JavadocMethod]
I'll quickly create a follow up PR to fix that at #1621
Hi @raphw I think the milestone is wrong here and should be 1.14.14
, not 1.12.14
While testing attachment via byte-buddy on Windows, we noticed that the NamedPipe is not able to report back the current state if the attachment was started from a service account. This is possible with the normal attach-tools.jar so I investigated what the difference is and it turns out that the hotspot attachment uses named pipes with a SecurityDescriptor. See VirtualMachineImpl.c how that is done. This PR does the same thing in JNA and in our test the attachment works afterwards when started from a service account against a JVM started from a user.
VirtualMachineImpl.c
: