show-header false not obeyed when spec-url fails to load

rapi-doc / RapiDoc

RapiDoc -WebComponent for OpenAPI Spec

https://rapidocweb.com

MIT License

1.71k stars 285 forks source link

show-header false not obeyed when spec-url fails to load #913

Closed adamsussman closed 1 year ago

adamsussman commented 1 year ago

When "show-header" is set to "false" and there is a problem loading the "spec-url" (not found, auth error, etc), then the header is still displayed. When the spec url successfully loads, the header does not show.

   <rapi-doc
       show-header = "false"
       spec-url "some failing url"
   >

mrin9 commented 1 year ago

The reason we show the Doc title is for providing a context that which spec is having an issue.

We have clients who uses microservices and as a result have multiple specs, which they show on a single HTML page. now it will be confusing to just show error loading spec for some of them without giving a context