search

rapid-eth / rapid-adventures

Rapid Adventures - Activate Your Life
1 stars 0 forks source link

If user doesnt have metamask installed, dont blow up #131

Closed onpaws closed 4 years ago

onpaws commented 4 years ago

I noticed when testing out onboarding with a non Metamask enabled browser, it appears we dispatch an action that doesn't have a handler, so the default case catches it and at least at the time of writing, causes the whole app to blow up.

Thought it'd be nice to not blow up :) so that's what this PR aims to accomplish.

onpaws commented 4 years ago

Looks like there are existing properties (ethers.address or ethers.wallet) that could surface 'it worked!' type info for consumers like rapid-adventures

If there's a proper/idiomatic way we have in mind, I'm totally down to use that inside rapid-adventures! The idea with this PR is just to improve the UX for people who don't happen to have Metamask installed.