search

rapid-eth / rapid-adventures

Rapid Adventures - Activate Your Life
1 stars 0 forks source link

Built contracts from erc20-certificates 11/21/2019 12:36 PM EST #77

Closed onpaws closed 4 years ago

onpaws commented 4 years ago

Heads up: there is a merge conflict with the bytecode property of two of the contracts yielded by building rapid-collectibles. ECDSA.json and SafeMath.json.

Not sure if it's actually meaningful, but wanted to highlight here just in case.

The rest of the JSON seems to be identical, so if I were to hazard a guess, when contracts get compiled, possibly time is a factor affecting the bytecode output?

onpaws commented 4 years ago

I allowed the ERC20 Certs version of ECDSA and SafeMathto 'win' the merge conflict. Like we said it shouldn't matter anyway, since they don't get used, just mentioning here FYI

onpaws commented 4 years ago

@joeb000 it looks like you pulled this card back into 'in progress' - curious if that's intentional?