Pin berkshelf and ridley gems

[erran-r7]

recommended reviewers: @cdoughty-r7 @cmccrisken-r7 @abunn-r7

Problem

The Nexpose DeployInstallers build began failing since berks package depended on the #chef_server_url method which was removed from berkshelf/ridley@v4.4.0.

Solution

• Pinning berkshelf to v4.0.1.
• Pinning ridley to v4.3.2.

  References

• https://github.com/berkshelf/ridley/compare/v4.3.2...v4.4.0
• https://github.com/berkshelf/berkshelf/issues/1494, https://github.com/berkshelf/berkshelf/issues/1495, and https://github.com/berkshelf/ridley/issues/330
• Ridley::Chef::Config#chef_server_url was removed here.

[erran-r7]

Note that @cdoughty-r7 merged this after integration tests passed on our private jenkins instance so we merged despite the failed status in TravisCI which looks to be unrelated to any changes made here.

[cdoughty-r7]

There's an open issue for TravisCI issues: https://github.com/rapid7-cookbooks/nexpose/issues/23

[rhass-r7]

I think this pin should be within the Gemfile of our internal tools repo, not the cookbook. Is there any reason why we must do it here?

[erran-r7]

I think this pin should be within the Gemfile of our internal tools repo, not the cookbook. Is there any reason why we must do it here?

@rhass-r7 yep, pinning it in the internal repository has no effect because we use the Gemfile in this repository to execute in a bundler environment for creating the cookbook package via berks package.

On a side note — I was also initially under the impression that we should pin the version in our internal tools repository but that had no effect at all which lead me to discover that we use this repository's bundler environment.