Closed ssikdar-r7 closed 5 years ago
I didn't originally implement csv, because lines
and csv
in dap seem very similar to begin with: https://github.com/rapid7/dap/blob/master/lib/dap/output.rb
Can you verify the functionality? There are minor differences between both output handlers...
you're right! looked at the code, tried recreated some code snippets in ibr, and compared both tools functionality looks to be the same.
closing pull request!
With ruby dap if I take a json input and try to do a csv output:
If I try with godap:
Comparing the available outputs:
However at a quick look, looks like
lines
in fact is basically doing the function of csv w/ delims etc. ( Not sure if this completely true, I just took a quick look)My change was to register another
RegisterOutput
w/ factory function withcsv
(but maybe it should be in acsv.go
?)With my change: