search

rapid7 / leexportpy

Logentries Log Export application that gives you the ability to synchronize your Logentries data with 3rd parties.
MIT License
2 stars 7 forks source link

query response class migration #4

Closed stopal-r7 closed 8 years ago

stopal-r7 commented 8 years ago

I have started working on this query_response classes for different kind of responses we get from Logentries REST API like: Events or Statistics. And statistics currently can have two forms: groupby and timeseries. I have now completed it and migrated the rest of the code to this module.

We can now deprecate lerestresponse.py - and can remove it in the following release.

stopal-r7 commented 8 years ago

@m0wfo @StephenHynes7 @jfitzpatrick-r7

chrismlogentries commented 8 years ago

+1 looks good, my only concern is our crappy query response format is forcing clients like leexportpy to go to great lengths to make it pleasant. Also we need to make sure this isn't broken by additions like multi-calculate, e.t.c