search

rapid7 / metasploit-framework

Metasploit Framework
https://www.metasploit.com/
Other
34.13k stars 13.97k forks source link

RPC API module.search is significantly slower than msfconsole's search command #10586

Closed wchen-r7 closed 3 years ago

wchen-r7 commented 6 years ago

The Problem

The search command on msfconsole almost immediately shows the results, but when you search for the same thing using MsfRPC, it's significantly slower. The following demonstrates:

Search command from msfconsole:

search_in_msfconsole

Search API from RPC:

search_in_rpc

As you can see, the performance difference is huge.

Expected Behavior

The response time in RPC should be almost as quickly as msfconsole.

timwr commented 6 years ago

I guess only the search in msfconsole is using the cache: e.g https://github.com/rapid7/metasploit-framework/blob/master/lib/msf/ui/console/command_dispatcher/modules.rb#L395 as opposed to: https://github.com/rapid7/metasploit-framework/blob/master/lib/msf/core/rpc/v10/rpc_module.rb#L175

github-actions[bot] commented 3 years ago

Hi!

This issue has been left open with no activity for a while now.

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 30 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request.

dwelch-r7 commented 3 years ago

This was resolved with this PR #13998