rapid7 / metasploit-framework

Metasploit Framework
https://www.metasploit.com/
Other
34.16k stars 13.98k forks source link

bluekeep - undefined local variable or method rdp_connect #12332

Closed greentea47 closed 5 years ago

greentea47 commented 5 years ago

msf5 exploit(windows/cve_2019_0708_bluekeep_rce) > version Framework: 5.0.46-dev Console : 5.0.46-dev

Using the latest version I'm getting this error on every attempted execution:

[+] xx.xxx.xxx.xxx:3389 - The target is vulnerable. [-] xx.xxx.xxx.xxx:3389 - Exploit failed: NameError undefined local variable or method `rdp_connect' for # [*] Exploit completed, but no session was created.

h00die commented 5 years ago

You need to install all supporting files, not just the module itself. The specific files and multiple instructions on how to do this can be found in the PR you took the file from. Please follow directions.

greentea47 commented 5 years ago

I've done that. I followed these steps:

To test the BlueKeep exploit, ensure you've copied all four .rb files from this PR to the appropriate Metasploit directories, then restart msfconsole.

This PR includes changes to the core RDP library in Metasploit for this exploit.

lib/msf/core/exploit/rdp.rb
modules/auxiliary/scanner/rdp/cve_2019_0708_bluekeep.rb
modules/auxiliary/scanner/rdp/rdp_scanner.rb
modules/exploits/windows/rdp/cve_2019_0708_bluekeep_rce.rb

The error I gave still occurs.

alexfmoraes commented 5 years ago

I have the same issue, all the files were copied on the correct directories. It does not work :(

bcoles commented 5 years ago

all the files were copied on the correct directories

X

greentea47 commented 5 years ago

regardless of your snarky and oh so helpful reply, the fact is that myself and other users have followed the directions and still get the error. so, no, no doubt here.

OJ commented 5 years ago

image The path to the exploit that you've shown implies that you've put the exploit file in the wrong folder. While this doesn't matter, it does imply that you may have failed to put other files in the correct folders.

so, no, no doubt here.

I'm afraid there's still doubt here. The best thing to do is use git to pull the branch into your repository. If you're not doing that, and you are instead manually copying files, there's clearly room for error.

OJ commented 5 years ago

asciicast

bcoles commented 5 years ago

regardless of your snarky and oh so helpful reply, the fact is that myself and other users have followed the directions and still get the error. so, no, no doubt here.

Glad I could help

greentea47 commented 5 years ago

Glad I could help

Pathetic.

image The path to the exploit that you've shown implies that you've put the exploit file in the wrong folder. While this doesn't matter, it does imply that you may have failed to put other files in the correct folders.

so, no, no doubt here.

I'm afraid there's still doubt here. The best thing to do is use git to pull the branch into your repository. If you're not doing that, and you are instead manually copying files, there's clearly room for error.

Already did the git pull, before I opened this issue. And yes, that path was incorrect which I fixed right away but as you said it doesn't matter. Still getting the same error. All of the files are in the correct place. Not sure what else I can do but show you:

$ ls -la /opt/metasploit/lib/msf/core/exploit/rdp.rb -rw-r--r-- 1 root root 47024 Sep 15 18:51 /opt/metasploit/lib/msf/core/exploit/rdp.rb

$ ls -la /opt/metasploit/modules/auxiliary/scanner/rdp/ drwxr-xr-x 2 root root 4096 Sep 15 18:53 . drwxr-xr-x 86 root root 4096 May 28 22:03 .. -rw-r--r-- 1 root root 8482 Sep 15 18:52 cve_2019_0708_bluekeep.rb -rw-r--r-- 1 root root 5979 Sep 10 16:35 ms12_020_check.rb -rw-r--r-- 1 root root 3032 Sep 15 18:53 rdp_scanner.rb

$ ls -la /opt/metasploit/modules/exploits/windows/rdp/cve_2019_0708_bluekeep_rce.rb -rw-r--r-- 1 root root 39484 Sep 15 18:53 /opt/metasploit/modules/exploits/windows/rdp/cve_2019_0708_bluekeep_rce.rb

Looks like the correct locations to me as do the file sizes and permissions etc

bcoles commented 5 years ago

Already did the git pull

Are you cloning the repository to /opt/metasploit/ ? Do you have more than one Metasploit installed? Are you running msfconsole, thus executing the system Metasploit, or running ./msfconsole from within the git repo?