macOS installer does correctly link binaries

[RA80533]

I opened this issue to specifically address a set of problems I came across when examining #13947. The rest of this issue is a duplicate of the content from my comment.

---

It seems most of the installation logic is supposed to occur after the native installation process of the .pkg file through the post-install script (postinst):

#!/bin/sh
#
# Perform necessary metasploit setup steps
# after package is installed.
#

BINS="msfbinscan msfconsole msfd msfdb msfelfscan msfmachscan msfpescan msfrop msfrpc msfrpcd msfupdate msfvenom"

if [ -x /usr/sbin/update-alternatives -o -x /usr/bin/update-alternatives ] ; then
    for BIN in $BINS; do
        update-alternatives --install /usr/bin/$BIN $BIN /opt/metasploit-framework/bin/$BIN 100
    done
    echo "Run msfconsole to get started"
else
    echo "Run /opt/metasploit-framework/bin/msfconsole to get started"
fi

exit 0

• The script does not output anything to the console The calling line for the .pkg installation (msfupdate.erb#L122) is missing the -dumplog toggle flag.
• The relevant binaries are not linked on macOS update-alternatives does not exist on macOS. It's not clear if the script ever worked on macOS for this reason.

The installation process itself seems to unnecessarily require sudo simply to write its files in system-wide locations. It's quite a poor design decision.

[github-actions[bot]]

Hi!

This issue has been left open with no activity for a while now.

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 30 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request.

[RA80533]

/bump

[github-actions[bot]]

Hi!

This issue has been left open with no activity for a while now.

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 30 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request.

[github-actions[bot]]

Hi again!

It’s been 60 days since anything happened on this issue, so we are going to close it. Please keep in mind that I’m only a robot, so if I’ve closed this issue in error please feel free to reopen this issue or create a new one if you need anything else.

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request.