search

rapid7 / metasploit-framework

Metasploit Framework
https://www.metasploit.com/
Other
34.01k stars 13.94k forks source link

Fix "Manage Engine" to be "ManageEngine" #16674

Closed h00die closed 2 years ago

h00die commented 2 years ago

Fix "Manage Engine" to be "ManageEngine" in exploit/windows/http/manageengine_adshacluster_rce to be consistent with literally every other module.

I would update the link as well to https://security.szurek.pl/en/manage-engine-exchange-reporter-plus-unauthenticated-rce/

Arpit-mohankar commented 2 years ago

@h00die can i contribute to this?

gwillcox-r7 commented 2 years ago

@Arpit-mohankar Feel free to submit a PR to fix this, and then just make sure you link to this issue with "Fixes # " and then add after the # the number of the issue, which in this case would be 16674.

Arpit-mohankar commented 2 years ago

@gwillcox-r7 @bcoles plz help me to pass Metasploit Automation - Sanity Test Execution

gwillcox-r7 commented 2 years ago

@Arpit-mohankar Think that may be something on our side, please follow the instructions in the comments and open a new PR as per directions and if it occurs again I'll look into it further.

JustAnda7 commented 2 years ago

@gwillcox-r7 I would like to contribute to this issue. Is this issue still open?

h00die commented 2 years ago

ticket is still open, and https://github.com/rapid7/metasploit-framework/blob/master/modules/exploits/windows/http/manageengine_adshacluster_rce.rb#L14 is still there. have at it @JustAnda7