rapid7 / metasploit-framework

Metasploit Framework
https://www.metasploit.com/
Other
33.28k stars 13.8k forks source link

Mark rpc_meterpreter_read as deprecated #19019

Open adfoster-r7 opened 3 months ago

adfoster-r7 commented 3 months ago

Summary

We'll be introducing a new RPC method for generically making interactive read/write calls to session types such as Meterpreter/SMB/SQL/etc

We want to deprecate and remove the old method:

module RPC
class RPC_Session < RPC_Base

  def initialize(service)
    @deprecator = ActiveSupport::Deprecation.new('7.1', 'metasploit-framework')
    @deprecator.deprecate_methods(
      self.class,
      rpc_meterpreter_read: :rpc_interactive_read,
      rpc_meterpreter_write: :rpc_interactive_write
    )
    super(service)
  end

Motivation

We don't want to immediately remove this method or mark it as deprecated, as it would impact tooling that may not receive future updates (armitage).

github-actions[bot] commented 2 months ago

Hi!

This issue has been left open with no activity for a while now.

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 30 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request.