search

rapid7 / metasploit-framework

Metasploit Framework
https://www.metasploit.com/
Other
33.03k stars 13.74k forks source link

chore: remove repetitive words #19083

Closed fanqiaojun closed 1 month ago

fanqiaojun commented 1 month ago

remove repetitive words

Verification

List the steps needed to make sure this thing works

If you are opening a PR for a new module that exploits a specific piece of hardware or requires a complex or hard-to-find testing environment, we recommend that you send us a demo of your module executing correctly. Seeing your module in action will help us review your PR faster!

Specific Hardware Examples:

Complex Software Examples:

We will also accept demonstrations of successful module execution even if your module doesn't meet the above conditions. It's not a necessity, but it may help us land your module faster!

Demonstration of successful module execution can take the form of a packet capture (pcap) or a screen recording. You can send pcaps and recordings to msfdev@metasploit.com. Please include a CVE number in the subject header (if applicable), and a link to your PR in the email body. If you wish to sanitize your pcap, please see the wiki.

h00die commented 1 month ago

some of these are likely in the corresponding modules to the docs, @fanqiaojun do you want to take a stab at that as well?

github-actions[bot] commented 1 month ago

Thanks for your pull request! We require for all contributed code to come from a from a unique branch in your repository before it can be merged.

Please create a new branch in your fork of framework and resubmit this from that branch.

If you are using Git on the command line that may look like:

# Checkout the master branch
git checkout master

# Create a new branch for your feature
git checkout -b <BRANCH_NAME>

# Add your new files
git add modules/my-cool-new-module

# Commit your changes with a relevant message
git commit

# Push your changes to GitHub
git push origin <BRANCH_NAME>

# Now browse to the following URL and create your pull request!
# - https://github.com/rapid7/metasploit-framework/pulls

This helps protect the process, ensure users are aware of commits on the branch being considered for merge, allows for a location for more commits to be offered without mingling with other contributor changes and allows contributors to make progress while a PR is still being reviewed.

Please do resubmit from a unique branch, we greatly value your contribution! :tada:

fanqiaojun commented 1 month ago

some of these are likely in the corresponding modules to the docs, @fanqiaojun do you want to take a stab at that as well?

Of course. My Pleasure.

The github actions bot has closed this MR. I have reopened a new MR https://github.com/rapid7/metasploit-framework/pull/19087.

Please take a look. thanks