search

rapid7 / metasploit-framework

Metasploit Framework
https://www.metasploit.com/
Other
32.92k stars 13.71k forks source link

Revert "Sql sessions have correct history manager" #19113

Closed adfoster-r7 closed 3 weeks ago

adfoster-r7 commented 3 weeks ago

Reverts rapid7/metasploit-framework#18933 - relates to the memory leak spotted here: https://github.com/rapid7/metasploit-framework/issues/19098

Which may be causing memory issues here: https://github.com/rapid7/metasploit-framework/issues/19098

adfoster-r7 commented 3 weeks ago

Looks like this has been confirmed to be the history for crashing Kali/Ubuntu instances; We'll roll forward with a revert - and have a separate fix to bring back the history limiting logic that got lost here: https://github.com/rapid7/metasploit-framework/pull/18933/files#r1572614863

adfoster-r7 commented 3 weeks ago

Release Notes

Fixes a regression that caused Metasploit to leak memory, and sometimes crash

adfoster-r7 commented 3 weeks ago

cc @daniruiz - just a heads up that we've shipped an out of band release for fixing an msfconsole crash that Kali users were running into over here: https://github.com/rapid7/metasploit-framework/issues/19098

I'm not sure what way the issue triaging works for Kali, but the crash should be fixed in this tagged release https://github.com/rapid7/metasploit-framework/releases/tag/6.4.5 - and we also have a workaround here: https://github.com/rapid7/metasploit-framework/issues/19098#issuecomment-2066929575