rapid7 / metasploit-framework

Metasploit Framework
https://www.metasploit.com/
Other
32.92k stars 13.72k forks source link

add EVENT_DEPENDENT to vcenter vmon priv esc #19122

Closed h00die closed 3 weeks ago

h00die commented 3 weeks ago

Now that #17294 has landed, add the new EVENT_DEPENDENT to one of the modules which needed it.

Verification

adfoster-r7 commented 3 weeks ago

Looks like we'll have to add the new value to the validation tests here:

https://github.com/rapid7/metasploit-framework/blob/a554e5251c33ed2421ffec32221888553c581881/spec/support/lib/module_validation.rb#L63-L70

If you throw that in, hopefully CI passes 🤞 If not, I'll fix whatever else is needed as a separate PR

adfoster-r7 commented 3 weeks ago

Should be the final change:

diff --git a/spec/module_validation_spec.rb b/spec/module_validation_spec.rb
index 1a1c819110..fbf53d08a6 100644
--- a/spec/module_validation_spec.rb
+++ b/spec/module_validation_spec.rb
@@ -107,7 +107,7 @@ RSpec.describe ModuleValidation::Validator do
       end

       it 'has errors' do
-        expect(subject.errors.full_messages).to eq ['Reliability contains invalid values ["FIRST_ATTEMPT_FAIL"] - only ["first-attempt-fail", "repeatable-session", "unreliable-session"] is allowed']
+        expect(subject.errors.full_messages).to eq ['Reliability contains invalid values ["FIRST_ATTEMPT_FAIL"] - only ["first-attempt-fail", "repeatable-session", "unreliable-session", "event-dependent"] is allowed']
       end
     end

Or let me know if you want me to sort it out without any extra overhead on your end - sorry about that!

h00die commented 3 weeks ago

I won't be able to get to it for about 24hrs, so you'll likely have a quicker shot at it

adfoster-r7 commented 3 weeks ago

Release Notes

Adds additional reliability metadata to exploits/linux/local/vcenter_java_wrapper_vmon_priv_esc