search

rapid7 / metasploit-framework

Metasploit Framework
https://www.metasploit.com/
Other
32.92k stars 13.71k forks source link

Adds pattern to catch other arch and platform values #19125

Closed zgoldman-r7 closed 1 week ago

zgoldman-r7 commented 3 weeks ago

We noticed that thte mssql platform/arch detection would return the full @@version query result for both arch and platform, and have a very noisy result: Screenshot 2024-04-19 at 2 28 01 PM To test this, I'm not sure how to actually return a string that doesn't match the existing patterns, but just create a session (mssql_login createsession=true), and list them sessions and make sure the arch/platform looks right. You can also pry in to the method and change the string, or just make sure the tests actually look good & add/suggest more if it's not covered.

adfoster-r7 commented 3 weeks ago

Looks like the PR needs a rebase on master

adfoster-r7 commented 1 week ago

Release Notes

Updates mssql platform/arch fingerprinting to be more resilient